[buddypress-trac] [BuddyPress] #921: bp_group_has_members() - "order" parameter request
buddypress-trac
noreply at wordpress.org
Wed Oct 2 19:02:21 UTC 2013
#921: bp_group_has_members() - "order" parameter request
-------------------------------------------------+-------------------------
Reporter: r-a-y | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future
Component: Groups | Release
Severity: normal | Version:
Keywords: has-patch needs-testing 2nd-opinion | Resolution:
early-2.0 |
-------------------------------------------------+-------------------------
Changes (by boonebgorges):
* keywords: has-patch needs-testing 2nd-opinion => has-patch needs-testing
2nd-opinion early-2.0
Comment:
imath - thanks for the patch. I would definitely like to get this in, but
I do think that we'll want to think more about how some of it works.
The way you've reworked the handlers in buddypress-functions.php seems
less than ideal to me (we can do better, I think, than having special
cases just for 'groupmembers'). In particular, if we're going to require
component info in `bp_legacy_theme_object_template_loader()`, we should be
either (a) sending it along with the JS, or (b) getting it from some
centralized place where loop templates are registered.
This might, in fact, be a good time to rethink how the AJAX works here
more generally. What we have now is a nifty little system, but the hoops
you jump through in your patch demonstrate that it's not very flexible.
This could be done in conjuction with the new template pack slated for the
next release.
Let's look at this for 2.0.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/921#comment:8>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list