[buddypress-trac] [BuddyPress] #5184: creating a placeholder on drop down lists on profiles
noreply at wordpress.org
Wed Nov 27 15:01:22 UTC 2013
#5184: creating a placeholder on drop down lists on profiles
Reporter: haykayltduk | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 2.0
Component: XProfile | Version:
Severity: normal | Resolution:
Keywords: needs-patch |
Changes (by boonebgorges):
* milestone: 1.9 => 2.0
5184.patch updates full-patch.php to do the following:
- actually display the saved placeholder text when editing the field (this
hadn't been included in the original patch)
- format as an svn patch so we can see highlighting in trac
I think the basic functionality is good here, but there are a couple areas
of concern for me.
1. IMO, the UI needs some rethinking. Maybe this is my technical knowledge
peeking through, but the word "placeholder" to me denotes the greyed-out
text that appears in a text field before you start typing, like the HTML5
placeholder element. What you're proposing here is different from that
(though it could overlap by expanding the patch a bit). It feels to me
like the "placeholder" option should appear alongside the other options in
the sortable list. For one thing, this'd make it possible to put the null-
option somewhere other than the top of the list. For another, it'd
highlight the fact that the null-option is *just another option*, but it
so happens that it has a null value. I already suggested having a more
robust [Advanced] tab in my comment above, but if that's too heavy a lift,
then maybe another set of radio buttons for "empty value", like we have
for "default value".
2. I don't think the null option makes sense for checkbox fields.
3. Could/should this be expanded to support the 'placeholder' attribute
for text fields? Maybe it's a subject for a different ticket.
Let's try to get this together for 2.0.
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5184#comment:11>
More information about the buddypress-trac