[buddypress-trac] [BuddyPress] #5184: creating a placeholder on drop down lists on profiles
buddypress-trac
noreply at wordpress.org
Mon Nov 25 23:06:11 UTC 2013
#5184: creating a placeholder on drop down lists on profiles
-------------------------+------------------
Reporter: haykayltduk | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 1.9
Component: XProfile | Version:
Severity: normal | Resolution:
Keywords: needs-patch |
-------------------------+------------------
Comment (by r-a-y):
Thanks for the patches, haykayltduk.
I haven't tested the patches yet, but some quick thoughts:
* The new function should be in bp-core-functions.php because we could
potentially use the placeholder in other form contexts (like the settings
component, 3rd-party plugins, etc.).
* For patch 0002, any reason why we can't apply `esc_html()` directly in
the new function?
* For patch 0003, why isn't the new function used in line 763 of bp-
xprofile-classes.php?
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5184#comment:9>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list