[buddypress-trac] [BuddyPress] #5184: creating a placeholder on drop down lists on profiles
buddypress-trac
noreply at wordpress.org
Sun Nov 24 17:04:28 UTC 2013
#5184: creating a placeholder on drop down lists on profiles
-------------------------+------------------
Reporter: haykayltduk | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 1.9
Component: XProfile | Version:
Severity: normal | Resolution:
Keywords: needs-patch |
-------------------------+------------------
Changes (by DJPaul):
* keywords: has-patch => needs-patch
Comment:
Hi Anand,
Great patch. Thanks for your contributions at the WordCamp London
contributor day. A few tweaks are needed, and I've spoken to you about
these in person, but for the record here:
* Set up a "proper" dev environment so it's easier to test changes out :)
* `wp_filter_kses( $_POST["placeholder_{$field->type}"] )` should use
`sanitize_text_field()` and maybe `stripslashes()`.
* Some minor code style improvements -- spacing, tabs, etc, but we can fix
when we commit.
* PHPDoc for new function- -- again, we can add when we commit if needed.
Others: do we think we can get this into 1.9, or wait for 2.0?
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5184#comment:7>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list