[buddypress-trac] [BuddyPress] #5251: Notifications component minor issues in 1.9 beta 1

[buddypress-trac]

#5251: Notifications component minor issues in 1.9 beta 1
---------------------------+------------------
 Reporter:  henrywright    |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  1.9
Component:  Notifications  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  dev-feedback   |
---------------------------+------------------
Changes (by r-a-y):

 * keywords:   => dev-feedback
 * component:  Core => Notifications
 * milestone:  Awaiting Review => 1.9


Old description:

> I've come across the following minor issues after testing the new
> notifications component (in BP 1.9 Beta 1)
>
> 1. Visiting your own notifications page {{{members/my-
> username/notifications/}}} is allowed yet viewing another member's
> notifications page isn't {{{members/their-username/notifications/}}}.
> With this in mind, should the 'Notifications' navigation tab be shown
> when viewing a member's profile page {{{members/their-username/}}}?
> Currently it is. Might be worth hiding it in the same way as Settings and
> Messages are hidden.
>
> 2. When an @-mention is made in a blog post or blog post comment, no
> notification is created. My understanding is @-mentions notify the
> mentioned member only if the @-mention is in the first sentence (the
> excerpt) of the text. For me, in 1.9 beta 1, @-mentions do not trigger BP
> core notifications or emails regardless of where the @-mention appears in
> the blog post or comment text.
>
> 3. Using messages notiications as an example, when a notification is
> clicked on the notifications screen and the member is taken to their
> message inbox, the notifications count next to the notifications
> navigation tab isn't updated. Only once the user navigates away from the
> inbox does the count update to reflect that the notification has been
> read. i.e. decrease by 1.
>
> 4. On deleting a notification, should the member be promoted that there
> is no way back? Using BP whilst on my tablet is particularly tricky and
> sometimes I tap in the wrong area. This could result in notifications
> being deleted unintentionally.
>
> Aside from these minor issues, it seems to work great - entirely as
> intended and expected. I hope this helps

New description:

 I've come across the following minor issues after testing the new
 notifications component (in BP 1.9 Beta 1)

 ~~1. Visiting your own notifications page {{{members/my-
 username/notifications/}}} is allowed yet viewing another member's
 notifications page isn't {{{members/their-username/notifications/}}}. With
 this in mind, should the 'Notifications' navigation tab be shown when
 viewing a member's profile page {{{members/their-username/}}}? Currently
 it is. Might be worth hiding it in the same way as Settings and Messages
 are hidden.~~ - see r7593

 2. When an @-mention is made in a blog post or blog post comment, no
 notification is created. My understanding is @-mentions notify the
 mentioned member only if the @-mention is in the first sentence (the
 excerpt) of the text. For me, in 1.9 beta 1, @-mentions do not trigger BP
 core notifications or emails regardless of where the @-mention appears in
 the blog post or comment text.

 3. Using messages notiications as an example, when a notification is
 clicked on the notifications screen and the member is taken to their
 message inbox, the notifications count next to the notifications
 navigation tab isn't updated. Only once the user navigates away from the
 inbox does the count update to reflect that the notification has been
 read. i.e. decrease by 1.

 4. On deleting a notification, should the member be promoted that there is
 no way back? Using BP whilst on my tablet is particularly tricky and
 sometimes I tap in the wrong area. This could result in notifications
 being deleted unintentionally.

 Aside from these minor issues, it seems to work great - entirely as
 intended and expected. I hope this helps

--

Comment:

 Point 1 is addressed.  I used the `bp_core_can_edit_settings()` function
 for now to determine whether or not the "Notifications" profile nav tab
 should be shown, but in the future, we should have individual caps for
 this as well.  (FYI, the private messages component also uses
 `bp_core_can_edit_settings()`.)

 Point 2 - I cannot duplicate.  I just tested by creating a short blog post
 with an at-mention and I was able to get a notification.  Needs further
 testing with longer blog posts, etc.  Probably should be looked at in
 #2372 instead.

 Point 3 - I think this is a separate enhancement issue.  This is more
 cosmetic and requires some JS to be written.

 Point 4 - Sounds like a good idea.  Need some dev-feedback before
 proceeding.

 ----

 I also have a point 5 - the "Read" anchor text on the "Notifications"
 screen should be renamed to "Mark as read" for UX reasons.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5251#comment:2>
BuddyPress <http://buddypress.org/>
BuddyPress