[buddypress-trac] [BuddyPress] #5167: CSS breaks wp_editor on BP pages
buddypress-trac
noreply at wordpress.org
Wed Nov 20 14:45:22 UTC 2013
#5167: CSS breaks wp_editor on BP pages
-------------------------------------------------+--------------------
Reporter: netweblogic | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 1.9
Component: Core | Version: 1.8.1
Severity: normal | Resolution:
Keywords: ui-feedback has-patch needs-testing |
-------------------------------------------------+--------------------
Changes (by boonebgorges):
* keywords: ui-feedback => ui-feedback has-patch needs-testing
Comment:
Thanks very much for the feedback, hnla. You've convinced me that, on
balance, it's probably best to just change the styles and leave the
templates alone. Let's be sure to fix this problem the right way in the
new template pack.
5167.patch is my attempt at solving the problem stated here. It does two
things:
1) Removes all general style declarations for `#buddypress table` in favor
of table-class-specific declarations. I *think* I have caught them all;
please double check.
2) The editor style buttons can't be fixed in the same way - we just
happen to have class name overlap. Because embedding a wp_editor() within
BP content is probably a fairly common use case, I think we're justified
in including a few declarations that are specific to the editor (`.wp-
editor-wrap`), to fix the button styles.
Would like to get feedback from someone (esp hnla) before committing to
make sure this seems like a sane approach for 1.9.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5167#comment:6>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list