[buddypress-trac] [BuddyPress] #5029: display_comments=none does not work in activity loop

[buddypress-trac]

#5029: display_comments=none does not work in activity loop
--------------------------+---------------------------
 Reporter:  pollyplummer  |       Owner:  boonebgorges
     Type:  defect (bug)  |      Status:  closed
 Priority:  low           |   Milestone:  1.9
Component:  Activity      |     Version:  1.7
 Severity:  minor         |  Resolution:  fixed
 Keywords:                |
--------------------------+---------------------------
Changes (by boonebgorges):

 * owner:   => boonebgorges
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"7574"]:
 {{{
 #!CommitTicketReference repository="" revision="7574"
 Support more liberal params for disabling comments in bp_has_activities()

 The 'display_comments' argument of bp_has_activities() takes either a
 string
 value (such as 'threaded') or a bool false to disable comments altogether.
 However, the false check in the query method is strict, meaning that
 various
 analogous null values for display_comments were not recognized. In
 particular,
 the strict check made it impossible to disable activity comments via a
 querystring, as is often done in templates: ?display_comments=0.

 This changeset adds 0, '0', 'false', and 'none' to the possible values for
 the null display_comments value, to support the longtime codex
 suggestions.
 Changes are made at the level of bp_has_activities(), which means that the
 query method still requires a string false for $display_comments.

 Fixes #5029
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5029#comment:7>
BuddyPress <http://buddypress.org/>
BuddyPress