[buddypress-trac] [BuddyPress] #5245: bp_core_add_cropper_inline_js : float formatting conflict with javascript array

buddypress-trac noreply at wordpress.org
Fri Nov 15 11:35:09 UTC 2013


#5245: bp_core_add_cropper_inline_js : float formatting conflict with javascript
array
--------------------------+-----------------------------
 Reporter:  olivM         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Core          |    Version:  1.8.1
 Severity:  normal        |   Keywords:  has-patch
--------------------------+-----------------------------
 with some locales ( fr_FR for exemple ) the decimal separator for floating
 number is the comma.
 so in PHP, the result of some division can include a comma.

 it will breaks the javascript arrays defined in
 bp_core_add_cropper_inline_js()

 the fix is to round the result of the division

 patch attached

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5245>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list