[buddypress-trac] [BuddyPress] #5239: New 1.9 feature : BuddyPress links box to nav-menus.php troubles

[buddypress-trac]

#5239: New 1.9 feature : BuddyPress links box to nav-menus.php troubles
--------------------------+-----------------------------
 Reporter:  imath         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Core          |    Version:  1.8.1
 Severity:  normal        |   Keywords:  has-patch
--------------------------+-----------------------------
 Hi,

 I've just checked this great new feature introduced in [7427] in WordPress
 3.7.1 & BuddyPress 1.9-alpha-7287 and found two troubles.

 1/ In bp-core/bp-core-functions.php function
 bp_nav_menu_get_loggedin_pages() at line the cached variable returned is
 causing an error as soon as more than one user nav link has been set in
 the wp_nav_menu. I think the reason is the variable should be
 {{{buddypress()->wp_nav_menu_items->loggedin}}} instead of
 {{{buddypress()->wp_nav_menu_items}}}

 2/ From the WordPress Appearance/Menus Administration screen, the checkbox
 "Log in" in the second box for "Logged-Out links" is not added to the menu
 when checked. I think the reason is that the div {{{tabs-panel-
 posttype-<?php echo $post_type_name; ?>-loggedout}}} doesn't have a
 {{{tabs-panel-active}}} class.

 So i suggest the diff attached to this ticket as it seems to correct these
 two troubles.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5239>
BuddyPress <http://buddypress.org/>
BuddyPress