[buddypress-trac] [BuddyPress] #5237: BuddyPress arbitrarily changes user field type

[buddypress-trac]

#5237: BuddyPress arbitrarily changes user field type
--------------------------+---------------------------
 Reporter:  sgr33n        |       Owner:  boonebgorges
     Type:  defect (bug)  |      Status:  closed
 Priority:  highest       |   Milestone:  1.9
Component:  XProfile      |     Version:
 Severity:  blocker       |  Resolution:  fixed
 Keywords:                |
--------------------------+---------------------------
Changes (by boonebgorges):

 * owner:   => boonebgorges
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"7564"]:
 {{{
 #!CommitTicketReference repository="" revision="7564"
 Prevent admin fiddling with Fullname field with properly narrow
 conditions.

 BP prevents admins from editing the visibility and field type settings of
 the
 Fullname field, because BP needs it to be public and a textarea. However,
 BP
 was enforcing this edit block by checking the `can_delete` flag of the
 BP_XProfile_Field object. In practice, it's usually the case that only
 field 1
 will have the value of `can_delete = 0`. However - especially due to
 changes in
 [7419] - other fields can have `can_delete = 0` as well. The edit block
 should
 therefore be more specific, based on the ID of the field rather than on
 the
 value of can_delete.

 Fixes #5237
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5237#comment:3>
BuddyPress <http://buddypress.org/>
BuddyPress