[buddypress-trac] [BuddyPress] #5148: Make notifications a separate component

buddypress-trac noreply at wordpress.org
Sun Nov 10 03:03:33 UTC 2013

#5148: Make notifications a separate component
 Reporter:  johnjamesjacoby       |       Owner:  johnjamesjacoby
     Type:  defect (bug)          |      Status:  new
 Priority:  normal                |   Milestone:  1.9
Component:  Notifications         |     Version:
 Severity:  normal                |  Resolution:
 Keywords:  needs-patch needs-ui  |

Comment (by vhauri):

 Ok, here's a first stab at the functionality outlined above, using the
 first option for paginated notifications (i.e. reverses sort and sends the
 user back to the first page of that sort order). Possible red flags:

 * We're checking a $_GET var directly to set the selected value of the
 select input in /bp-templates/bp-
 legacy/buddypress/members/single/notifications.php. I'm doing this because
 it seems the BP_Notifications_Template object has not yet instantiated at
 that point with the corresponding sort_order property. If there's a better
 way to do this, the code should be updated to use that.

 * JS is being enqueued in bp-notifications-template.php conditionally when
 the object finds notifications for the user. This is great performance-
 wise, but I'm not sure if it's the right place for the enqueue.

 * The closing </tbody> tag must be fixed (included in this patch) for the
 JS to work--otherwise it will balk at the presence of multiple tbody tags
 in the table.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5148#comment:46>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list