[buddypress-trac] [BuddyPress] #5231: Number format not being applied

[buddypress-trac]

#5231: Number format not being applied
--------------------------+------------------------------
 Reporter:  sgr33n        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Core          |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------------------

Comment (by boonebgorges):

 Yes, you're right.

 Our treatment of number format is inconsistent in the activity/index.php
 template. It's mostly my fault. See #4997 [7177], #5228 [7516].

 I've done an audit of the _count() functions used in this template, and
 applied the following logic:
 - All number formatting should be done in the -template.php files, as
 filters applied to the output (`add_filter( hook, 'bp_core_number_format'
 )`)
 - No number formatting should be done in the template
 - Add format filters to functions where it was missing
 - When creating Groups tabs, use `%s` rather than `%d` to account for
 number formats

 I believe this should be consistent across templates.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5231#comment:1>
BuddyPress <http://buddypress.org/>
BuddyPress