[buddypress-trac] [BuddyPress] #5212: Enable upgrade route for BP-Default for future BP releases

[buddypress-trac]

#5212: Enable upgrade route for BP-Default for future BP releases
--------------------------+------------------
 Reporter:  DJPaul        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  2.0
Component:  Theme         |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------

Comment (by johnjamesjacoby):

 Replying to [comment:4 boonebgorges]:
 > 1. What's the advantage of copying over the files from bp-themes, rather
 than (a) ensuring that bp-default is available on wp.org/extend on the day
 2.0 drops, and then (b) using WP's theme downloader library to force the
 download? It seems like we *might* need to write less code if we use WP's
 library, and somehow it seems "right" to download the theme anew rather
 than copying from within BP.
 > 2. Related to 1. We have to consider installations where file
 permissions etc will not allow BP to move files around. Maybe another
 argument for using as much of the existing WP interface as possible.
 > 3. I'll have to look at the theme options stuff, but do some of them
 save theme-directory paths? If so, we'll have to run some processing on
 the theme options when moving them over.
 > 4. I think there's not much purpose in actively deleting bp-default out
 of the buddypress directory. Let's either: ship it with 2.0 and use it as
 a fallback if the automated migration fails (and don't register the theme
 directory otherwise; see #5223), or don't ship it with 2.0 at all and
 force admins to complete the migration before the site is usable. Deleting
 files on the fly from BP seems sketchy to me, especially in production
 environments that are under version control, etc.
 1. Only advantage is knowing we tried to be helpful I suppose.
 2. Falls under my 'if anything fails' clause.
 3. Falls under my 'update the appropriate theme options' clause.
 4. Agree, and on board.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5212#comment:6>
BuddyPress <http://buddypress.org/>
BuddyPress