[buddypress-trac] [BuddyPress] #4551: Use WP's metadata API (was: groups_get_groupmeta should allow filtering the value)
buddypress-trac
noreply at wordpress.org
Wed May 29 22:13:32 UTC 2013
#4551: Use WP's metadata API
-------------------------------------+-----------------------------
Reporter: sbrajesh | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Core | Version: 1.2
Severity: normal | Resolution:
Keywords: has-patch needs-refresh |
-------------------------------------+-----------------------------
Changes (by r-a-y):
* severity: minor => normal
* version: 1.6.1 => 1.2
* milestone: 1.8 => Future Release
Comment:
I like the idea behind the patch, but I don't like how we're duplicating
the entire WP meta API to accomplish this because we are unable to
override some variables.
sbrajesh is correct that we should pass a patch upstream to filter
`_get_meta_table()` and to the various hardcoded variables in the
*_metadata() functions like
[https://core.trac.wordpress.org/browser/tags/3.5.1/wp-
includes/meta.php#L114 this].
This would prevent so much code duplication. The other issue I can see is
maintaining backpat cache with our own cache keys (if that is even
necessary).
I'll post a patch upstream and will update this ticket, but until then I'm
pushing this back to Future Release.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4551#comment:9>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list