[buddypress-trac] [BuddyPress] #5021: Shortcode contents don't display in non-standard BP 1.7 themes

[buddypress-trac]

#5021: Shortcode contents don't display in non-standard BP 1.7 themes
------------------------------------+------------------
 Reporter:  sensibleplugins         |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  1.8
Component:  Core                    |     Version:  1.7
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------

Comment (by r-a-y):

 > The problems don't manifest with single post pages (like single Docs, or
 with bp-pages, which are single WP posts), but only with post type
 archives like those used in BP Docs directories.

 This was the problem; I was only testing on single pages.

 05.patch makes a lot of sense.  My 4.patch's runonce idea isn't needed
 anymore since 05.patch removes the `loop_start` hook within
 `bp_theme_compat_main_loop_start()`.

 > We found that, by removing the re-adding of the bp_replace_the_content
 filter in bp_buffer_template_part(), the second level of recursion was
 avoided too.

 Yes, I missed this since we now add `bp_replace_the_content` in
 `bp_theme_compat_main_loop_start()`.  Good catch!

 ----

 After thinking about it more, we don't even need the `'loop_end'` hook.
 We should just restore all filters in `bp_buffer_template_part()` after
 we've done our object buffering immediately.

 06.patch implements these ideas as well as adds back the
 `$wp_query->post_count` check from 4.patch.  I still think the post_count
 check is valuable for plugin or theme devs that might use `query_posts()`
 unnecessarily, but I'm open to removing this.

 Let me know what you think.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5021#comment:13>
BuddyPress <http://buddypress.org/>
BuddyPress