[buddypress-trac] [BuddyPress] #5021: Shortcode contents don't display in non-standard BP 1.7 themes
buddypress-trac
noreply at wordpress.org
Wed May 29 01:03:03 UTC 2013
#5021: Shortcode contents don't display in non-standard BP 1.7 themes
------------------------------------+------------------
Reporter: sensibleplugins | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 1.8
Component: Core | Version: 1.7
Severity: normal | Resolution:
Keywords: has-patch dev-feedback |
------------------------------------+------------------
Comment (by johnjamesjacoby):
Originally, the reason filters were removed from 'the_content' when they
were, is because some functions in bbPress were using the 'the_content'
filter in a way where it was possible to accidentally nest them. This is
still currently possible with bbPress's shortcodes, which is why the
output buffer start and end methods
[http://bbpress.trac.wordpress.org/browser/trunk/includes/common/shortcodes.php#L139
conveniently remove and add] bbp_replace_the_content() from 'the_content'
before putting out content to the output buffer.
Since we're not using 'the_content' anywhere else in BuddyPress at the
moment, it's possible we can dial this into more narrow actions. I'd like
to shy away from create_function() though, since I suspect we'll need to
add more logic to these new functions over time.
A few things to consider here:
* Are there any issues with 5021.02.patch and loop_end and loop_start
firing on all query loops?
* Does this accidentally trigger those actions on sidebars, etc?
* Are we accidentally running content through the 'the_content' filter
twice? Or, are we skipping it on accident now?
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5021#comment:5>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list