[buddypress-trac] [BuddyPress] #5029: display_comments=none does not work in activity loop

[buddypress-trac]

#5029: display_comments=none does not work in activity loop
--------------------------+------------------
 Reporter:  pollyplummer  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  low           |   Milestone:  1.8
Component:  Activity      |     Version:  1.7
 Severity:  minor         |  Resolution:
 Keywords:                |
--------------------------+------------------
Changes (by boonebgorges):

 * priority:  normal => low
 * severity:  normal => minor
 * milestone:  Awaiting Review => 1.8


Comment:

 hnla - Yes, I've found the same thing. It's possible to exclude comments
 like this:

 {{{
 if ( bp_has_activities( array(
     'display_comments' => false,
 ) ) )
 }}}

 But not using any querystring format, and not using the 'none' keyword,
 and not passing a 0.

 At least some of these issue should be fixed at some point, but there are
 complications. I can't simply cast things to boolean, because of r3985,
 which I don't totally understand but would probably be broken by messing
 with the strict type check.

 I've run out of time to look at this at the moment, so I'm going to move
 it to 1.8 and hopefully look at it in more detail in the upcoming days.
 Though, it's definitely not a regression, so it may get bumped.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5029#comment:5>
BuddyPress <http://buddypress.org/>
BuddyPress