[buddypress-trac] [BuddyPress] #5029: display_comments=none does not work in activity loop

[buddypress-trac]

#5029: display_comments=none does not work in activity loop
--------------------------+------------------------------
 Reporter:  pollyplummer  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Activity      |     Version:  1.7
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------------------

Comment (by hnla):

 I have just run through bp_has_activities() for Sarah to see what was
 what.

 Firstly Codex entry is now inaccurate stating  two things:
 1. that the default value of $display_comments is 'none'.
 2. passing a string 'none' hides display of comments.

 Function sets :
   $defaults = array(
    'display_comments' => 'threaded',

 and requires bool false to hide display '// false for none,
 stream/threaded - show comments in the stream'

 I checked and passing a string equiv to 'display_comments=0' works to hide
 as as far as I remember passing zero as a string or otherwise is
 technically bool false.

 I'll add an update to the codex page to reflect this while leaving older
 entries in place but we may need to consider if passing string '0' is
 actually valid even if does seem to work - I'm not sure on that aspect.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5029#comment:1>
BuddyPress <http://buddypress.org/>
BuddyPress