[buddypress-trac] [BuddyPress] #5019: Fire 'friends_friendship_deleted' hook after delete friendship.

buddypress-trac noreply at wordpress.org
Mon May 27 13:58:43 UTC 2013


#5019: Fire 'friends_friendship_deleted' hook after delete friendship.
---------------------------+---------------------------
 Reporter:  mukkundthanki  |       Owner:  boonebgorges
     Type:  defect (bug)   |      Status:  closed
 Priority:  low            |   Milestone:  1.8
Component:  Friends        |     Version:  1.7
 Severity:  minor          |  Resolution:  fixed
 Keywords:  2nd-opinion    |
---------------------------+---------------------------

Comment (by mukkundthanki):

 Replying to [comment:3 boonebgorges]:
 > In [changeset:"7108"]:
 > {{{
 > #!CommitTicketReference repository="" revision="7108"
 > Introduce friends_friendship_post_delete hook
 >
 > The existing hook friends_friendship_deleted hook actually fires before
 the
 > friendship count is deleted in the database. This causes problems for
 plugins
 > that want to access the updated user friend counts, and other info that
 is
 > changed at the time of delete.
 >
 > Fixes #5019
 >
 > Props mukkundthanki
 > }}}


 I don't think hook will work after return true statement. we should put it
 right before return true. It will work fine there because condition let it
 run if friendship is successfully deleted.

 Thanks

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5019#comment:4>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list