[buddypress-trac] [BuddyPress] #4844: Show all X comments should update when comments are deleted
buddypress-trac
noreply at wordpress.org
Mon May 6 00:49:23 UTC 2013
#4844: Show all X comments should update when comments are deleted
--------------------------+------------------
Reporter: modemlooper | Owner:
Type: defect (bug) | Status: new
Priority: low | Milestone: 1.8
Component: Activity | Version: 1.7
Severity: minor | Resolution:
Keywords: has-patch |
--------------------------+------------------
Comment (by boonebgorges):
> I don't think updating the X in "Show all X comments" is worth the
trouble. I think it's pretty understandable from the user's point of view.
I might've been tempted to agree with this. But then I looked at the way
this string is currently generated, and was so repulsed that I knew it had
to be rewritten :) Basically, we were piecing it together like this: "Show
all" + " " + comment_count + " " + "comments". Beyond being breathtakingly
ugly, this is extremely untranslatable.
I've refactored the way that the show-all text is generated, so that (a)
it's possible to translate it, and (b) it's easy to write javascript to
update the number after deletion. Win-win!
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4844#comment:8>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list