[buddypress-trac] [BuddyPress] #4972: Purpose of bp_is_user_deleted()?

[buddypress-trac]

#4972: Purpose of bp_is_user_deleted()?
--------------------------+-----------------------------
 Reporter:  r-a-y         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Members       |    Version:  1.5.2
 Severity:  normal        |   Keywords:  dev-feedback
--------------------------+-----------------------------
 While auditing the `bp_is_user_deleted()` function, I was wondering what
 the use-case is for this function.

 Two other things:

 1) https://buddypress.trac.wordpress.org/browser/tags/1.7.1/bp-members/bp-
 members-functions.php#L708

 WP core doesn't use this flag anymore, but I'm guessing it's from the old
 WPMU days.  I can't name an instance when this will ever be used.  Perhaps
 in some really old plugins?

 2) https://buddypress.trac.wordpress.org/browser/tags/1.7.1/bp-members/bp-
 members-functions.php#L711

 BP uses this flag internally for accounts that haven't been activated yet.

 But the function name is called `bp_is_user_deleted()`.  Shouldn't we move
 the `user_status == 2` check into `bp_is_user_active()` instead?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4972>
BuddyPress <http://buddypress.org/>
BuddyPress