[buddypress-trac] [BuddyPress] #4869: BP Theme Compat & BuddyPress Widgets styles
buddypress-trac
noreply at wordpress.org
Mon Mar 25 20:00:07 UTC 2013
#4869: BP Theme Compat & BuddyPress Widgets styles
----------------------------------------+---------------------
Reporter: imath | Owner:
Type: enhancement | Status: closed
Priority: normal | Milestone: 1.7
Component: Theme | Version: 1.7
Severity: normal | Resolution: fixed
Keywords: has-patch needs-unit-tests |
----------------------------------------+---------------------
Changes (by boonebgorges):
* status: new => closed
* resolution: => fixed
Comment:
(In [6866]) Moves some core theme compatibility logic to the
BP_Theme_Compat parent class
Since every new BP template pack will need to do the same kinds of checks
before starting the theme compat process (is this a child theme of bp-
default,
etc), it makes sense for a parent::start() method to handle the logic,
rather
than requiring individual template packs to reproduce it in their child
classes.
In addition, this changeset introduces a fallback check for legacy
BuddyPress
themes. For themes that are not child themes of bp-default and also have
not
declared current_theme_supports( 'buddypress' ), BP_Theme_Compat::start()
now
checks for the existence of members/members-loop.php in the current theme,
and
if found, it interprets it as a sign that the current theme does indeed
support
BuddyPress, and that theme compatibility should be aborted. Theme authors
are
still urged to use current_theme_supports( 'buddypress' ) in their
template
packs.
Fixes #4869
Props r-a-y
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4869#comment:10>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list