[buddypress-trac] [BuddyPress] #4869: BP Theme Compat & BuddyPress Widgets styles
buddypress-trac
noreply at wordpress.org
Thu Mar 21 12:59:18 UTC 2013
#4869: BP Theme Compat & BuddyPress Widgets styles
-------------------------+------------------
Reporter: imath | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 1.7
Component: Theme | Version: 1.7
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+------------------
Comment (by boonebgorges):
At a glance, I mostly like this method much better. Doing the logic in the
base `BP_Theme_Compat` sense makes much, much more sense.
The `locate_template()` brute-force is somewhat unelegant and inefficient.
I worry about running this kind of `locate_template()` call on every
single page load (which is what will happen in cases where theme compat
actually ends up running). Is it possible to cache this value somewhere
where it'll be more easily accessible? Or am I being overly concerned
about a miniscule bit of overhead?
The multisite/multiblog stuff is good, though it undercuts the original
point of this ticket, which is that styles need to be loaded where the
members/groups widgets are loaded - which is possible on non-root blogs. I
guess the correct solution for that particular issue is to put some
minimal styles into a separate stylesheet, and then enqueue it from the
widget's display method.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4869#comment:5>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list