[buddypress-trac] [BuddyPress] #4879: add_theme_support( 'buddypress' ) should not load buddypress-functions.php

[buddypress-trac]

#4879: add_theme_support( 'buddypress' ) should not load buddypress-functions.php
--------------------------------------------+------------------------------
 Reporter:  modemlooper                     |       Owner:
     Type:  defect (bug)                    |      Status:  new
 Priority:  normal                          |   Milestone:  Awaiting Review
Component:  Backwards Compatability         |     Version:  1.7
 Severity:  major                           |  Resolution:
 Keywords:  dev-feedback reporter-feedback  |
--------------------------------------------+------------------------------

Comment (by boonebgorges):

 > I think add_theme_support( 'buddypress' ) should not load buddypress-
 functions.php

 To repeat: while it's true that we are loading the file, it shouldn't
 actually do anything as long if your current_theme_supports( 'buddypress'
 ). So I don't see a functional difference between what we currently do and
 what you are suggesting.

 I'm guessing that you have copied buddypress-functions.php into your own
 theme, and in the process you are double-defining many function names.
 Didn't you have to change them to clear duplicate function name errors?
 Again, if you would be willing to share the code that you are using, it
 would be a lot easier to help to debug the issue.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4879#comment:3>
BuddyPress <http://buddypress.org/>
BuddyPress