[buddypress-trac] [BuddyPress] #4671: BuddyPress Default Components

[buddypress-trac]

#4671: BuddyPress Default Components
-----------------------------+------------------------------
 Reporter:  johnjamesjacoby  |       Owner:  johnjamesjacoby
     Type:  task             |      Status:  reopened
 Priority:  high             |   Milestone:  1.7
Component:  Administration   |     Version:
 Severity:  normal           |  Resolution:
 Keywords:                   |
-----------------------------+------------------------------

Comment (by boonebgorges):

 (In [6842]) Improves the save routine for the Components Dashboard page

 The subtabs of the Components Dashboard page (All, Active, Inactive, Must
 Use,
 Retired) all work differently in terms of how data is returned from them.
 Some
 of the subtabs - All and Active - are accurate reflections of the
 components
 that the user currently wants to be active. Retired and Inactive, on the
 other
 hand, don't contain complete data about which components are supposed to
 be
 turned on. For that reason, we can't trust the checkbox data submitted
 through
 the POST when setting the active components.

 This changeset introduces
 bp_core_admin_get_active_components_from_submitted_settings(),
 which handles the logic necessary to determine which components the user
 intends to be active, based on the data submitted in the POST request.
 It's
 been separated out into a standalone function for better unit testing.

 Test: https://github.com/buddypress/BuddyPress-Unit-
 Tests/commit/49e72ea3fc1f103ab6336c79f5c5b66294f4aad6

 See #4671

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4671#comment:14>
BuddyPress <http://buddypress.org/>
BuddyPress