[buddypress-trac] [BuddyPress] #5067: If mentions are disabled @username may not show in member's header
buddypress-trac
noreply at wordpress.org
Sat Jun 22 20:06:25 UTC 2013
#5067: If mentions are disabled @username may not show in member's header
-------------------------+-----------------------
Reporter: imath | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 1.8
Component: Members | Version: 1.8-beta
Severity: normal | Resolution:
Keywords: has-patch |
-------------------------+-----------------------
Changes (by boonebgorges):
* milestone: Awaiting Review => 1.8
Comment:
Good catch, imath.
I think that your patch is a bit more complex than what we really need.
Burying the theme compat check inside of a template function seems wrong
to me, especially since we're moving away from bp-default. And we
generally prefer to avoid creating markup inside of functions if we can
help it.
This is a case where the best solution is the simplest: putting
`bp_activity_do_mentions()` checks right into the templates.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5067#comment:1>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list