[buddypress-trac] [BuddyPress] #4949: Revise enqueue style locations for theme compat

buddypress-trac noreply at wordpress.org
Mon Jun 10 07:44:17 UTC 2013


#4949: Revise enqueue style locations for theme compat
-------------------------------------------------+------------------
 Reporter:  hnla                                 |       Owner:
     Type:  enhancement                          |      Status:  new
 Priority:  low                                  |   Milestone:  1.8
Component:  Theme                                |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch 2nd-opinion needs-testing  |
-------------------------------------------------+------------------

Comment (by hnla):

 >I did have to change your logic a little bit. Your is_child_theme() check
 means that the parent theme is not consulted if the child theme doesn't
 have the assets. This is not how theme compat works for templates - we
 first check the child, then check the parent, not one or the other.

 I thought my use in this context was valid my tests returned my expected
 results, if is_child_theme() returned false I used
 get_template_directory() to check the parent path.

 I'll run your patch, test & report back.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4949#comment:6>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list