[buddypress-trac] [BuddyPress] #5045: BP Legacy members settings templates markup issues

[buddypress-trac]

#5045: BP Legacy  members settings templates markup issues
--------------------------+------------------
 Reporter:  hnla          |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  1.8
Component:  Theme         |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------
Changes (by boonebgorges):

 * milestone:  Awaiting Review => 1.8


Comment:

 > In practice, i think home.php doesn't load settings.php. This means that
 general.php and notifications.php are loaded directly and settings.php
 isn't used.

 I'm pretty sure that's not right. I seem to remember that something like
 this happened in a recent version of bp-default, but bp-legacy in the
 master branch definitely loads home.php -> settings.php -> general.php,
 and so on.

 > Deleting these additional elements from the inner template_parts ought
 to cause no issue as they are dups

 Yes. It appears that they are dupes, and they've just gone unnoticed since
 bp-legacy was first copied over in r6284.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5045#comment:2>
BuddyPress <http://buddypress.org/>
BuddyPress