[buddypress-trac] [BuddyPress] #4953: BuddyPress specific UI refresh

[buddypress-trac]

#4953: BuddyPress specific UI refresh
-------------------------------------+------------------
 Reporter:  karmatosed               |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  1.8
Component:  UX/UI                    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------
Changes (by boonebgorges):

 * keywords:  has-patch => has-patch needs-testing


Comment:

 Great work with this project, karmatosed et al.

 I just spent a time testing out the changes with a handful of popular
 themes. Overall, the detheming has a very nice effect - it's great to see
 stuff like font faces and button styling being inherited from themes more
 elegantly. Makes it look less like bp-default.

 The only obvious issue I found was with button text size. First, there was
 a line-height: 14px in there that looks like it should be removed. Second,
 by removing the font-size declaration, buttons are getting set to 1em.
 IMO, this is too big. The "Create a Group" button in the groups directory,
 for instance, ends up being enormous, because it inherits the `<h1>` font-
 size. Even the 'Join Group' buttons etc seem too large for me.

 4953.patch removes the stray line-height, and sets button font-size to
 .8rem. I noticed that percentages were being used throughout the
 stylesheet for font-size, but since buttons appear in many contexts (as
 children of elements with different `font-size` values), using `font-size:
 80%;` made the button text too large in some cases and too small in
 others. Thus, rem. Let me know what you think about that.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4953#comment:21>
BuddyPress <http://buddypress.org/>
BuddyPress