[buddypress-trac] [BuddyPress] #4794: Calling bp_core_new_nav_item() without screen_function parameter generates PHP warning

[buddypress-trac]

#4794: Calling bp_core_new_nav_item() without screen_function parameter generates
PHP warning
-------------------------------------+---------------------------
 Reporter:  doublesharp              |       Owner:  boonebgorges
     Type:  defect (bug)             |      Status:  closed
 Priority:  normal                   |   Milestone:  1.8
Component:  Warnings/Notices         |     Version:  1.2
 Severity:  normal                   |  Resolution:  fixed
 Keywords:  has-patch needs-testing  |
-------------------------------------+---------------------------
Changes (by boonebgorges):

 * owner:   => boonebgorges
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"7171"]:
 {{{
 #!CommitTicketReference repository="" revision="7171"
 Use is_callable() to validate screen_function callbacks before hooking in
 bp-core-buddybar.php

 We were previously using is_object() and other custom verification
 techniques
 to hook screen functions in bp_core_new_nav_item() and elsewhere. These
 techniques are limited in that they allow certain sorts of uncallable
 strings
 to pass through. We also should not be reinventing the wheel.

 Fixes #4794

 Props r-a-y
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4794#comment:9>
BuddyPress <http://buddypress.org/>
BuddyPress