[buddypress-trac] [BuddyPress] #5036: Standalone theme with partial templates copied over uses theme compat to render missing templates

[buddypress-trac]

#5036: Standalone theme with partial templates copied over uses theme compat to
render missing templates
--------------------------+-----------------------------
 Reporter:  hnla          |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Core          |    Version:
 Severity:  minor         |   Keywords:
--------------------------+-----------------------------
 This ticket for reference following on from IRC chat with Bone & JJJ.

 Note: The described scenario is not intended as a real world one but was a
 happenstance with a site install missing register.php as manual user
 registration in effect.

 Nub of the question is:
 ''
 In the event of a standalone theme missing templates from bp-default
 should theme compat kick in and render them via page.php or equivalent
 when the theme states add_theme_support('buddypress') and also has members
 /members-loop.php in place ( two checks to disable theme compat).
 ''

 Scenario was a standalone theme with most bp-default templates copied over
 except /registration/
 functions.php overloaded bp_dtheme_setup() and copied all necessary calls
 to run BP including add_theme_support('buddypress')

 Expected behaviour with missing templates would have been a white screen
 however in practise theme compat was cutting in and acting as though theme
 compat was in effect and injecting content to page.php despite the theme
 setting two parameters that theme compat should check before proceeding.

 This may or may not be a bug but not specifically labelling it as such as
 the test case in my opinion not a valid one as a method moving forward
 with theme compat and theme development.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5036>
BuddyPress <http://buddypress.org/>
BuddyPress