[buddypress-trac] [BuddyPress] #5106: Better sorting for new bp_group_has_members() query

[buddypress-trac]

#5106: Better sorting for new bp_group_has_members() query
--------------------------+--------------------
 Reporter:  aaclayton     |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  1.8.1
Component:  Groups        |     Version:  1.8
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+--------------------
Changes (by boonebgorges):

 * type:  enhancement => defect (bug)
 * milestone:  Awaiting Review => 1.8.1


Comment:

 Thanks for the report, aaclayton. I've confirmed the issue.

 The changed behavior for `bp_group_has_members()` is a bug. It was
 intended that `BP_Group_Member_Query` would sort by `last_modified`. See
 http://buddypress.trac.wordpress.org/browser/tags/1.8/bp-groups/bp-groups-
 classes.php#L1100. And when these values were passed back to
 `BP_User_Query`, it was intended that the query would preserve this
 sorting. I'll look into why this isn't happening, but the fact that it's
 not is a regression, so I'm moving the ticket to 1.8.1.

 As for the further request for better query params - I agree (see the
 inline todo!). Once I've fixed the regression in this ticket, I'll move
 this request to a separate enhancement ticket.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5106#comment:1>
BuddyPress <http://buddypress.org/>
BuddyPress