[buddypress-trac] [BuddyPress] #5103: Group slug and user's subnav parent_slug trouble

[buddypress-trac]

#5103: Group slug and user's subnav parent_slug trouble
--------------------------+-------------------------------------
 Reporter:  imath         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Core          |    Version:
 Severity:  major         |   Keywords:  needs-patch 2nd-opinion
--------------------------+-------------------------------------
 Hi,

 I was testing next version of BuddyDrive and then i've created a group
 with the name of BuddyDrive. Once the group was created the slug of the
 group is 'buddydrive'. Then i've noticed that the BuddyDrive user's subnav
 was showing on the group nav just after the Home one.

 I then thought, no problem i'll add buddydrive to the groups forbidden
 names. Then i ran some other tests by creating groups with these names :
 - Profile
 - friends
 - activity

 Once these groups were created, i have the component user's subnav in the
 group nav just like my BuddyDrive test (you can see screencaps for the 3
 groups).

 The problem is that as the parent_slug of for instance the Edit profile
 subnav is profile and match the group slug, then if the loggedin user ==
 the group creator (or if he's the superadmin), he has in the group nav his
 profile subnav etc..

 I guess a quick fix would be to add components slugs to the groups
 forbidden name array. On the other hand, i'm not sure it's a great
 solution as in the case of plugin's component, if the name of the group
 match the plugin's component slug before it has been installed, filtering
 the groups forbidden names will have no effect as at least one group were
 created with the parent_slug..

 What do you think ?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5103>
BuddyPress <http://buddypress.org/>
BuddyPress