[buddypress-trac] [BuddyPress] #5099: Total groups wrong when fetching groups with meta query
buddypress-trac
noreply at wordpress.org
Tue Jul 16 14:26:36 UTC 2013
#5099: Total groups wrong when fetching groups with meta query
--------------------------+-----------------------
Reporter: r-a-y | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 1.8
Component: Groups | Version: 1.8-beta
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+-----------------------
Comment (by boonebgorges):
Good catch, r-a-y.
I agree that the way we're assembling the total count here is not ideal.
Your patch seems like a good way forward in the future (though we can
probably also snip LIMIT and ORDER BY clauses as well). But, as you note,
it's a big change for 1.8. And since the bug is with a feature that is
being introduced for the first time in 1.8 (ie, this is neither a
regression nor a longtime bug), it seems fine to me to put a band-aid on
it for now, as in 5099.02.patch. Then, for 1.9, we can circle back around
to your more general suggestion.
Have a look at 5099.02.patch and let me know what you think.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5099#comment:2>
BuddyPress <http://buddypress.org/>
BuddyPress
More information about the buddypress-trac
mailing list