[buddypress-trac] [BuddyPress] #4794: Calling bp_core_new_nav_item() without screen_function parameter generates PHP warning

[buddypress-trac]

#4794: Calling bp_core_new_nav_item() without screen_function parameter generates
PHP warning
-------------------------------------+------------------
 Reporter:  doublesharp              |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  1.7
Component:  Warnings/Notices         |     Version:  1.2
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------
Changes (by r-a-y):

 * keywords:  needs-patch => has-patch needs-testing


Comment:

 02.patch is another approach to this issue.

 I like this better as:
 * We don't have to explicitly set the default screen function to
 `__return_false()`
 * We can check the existence of the screen function with is_callable() for
 both methods and functions.

 Tested lightly with default BP components and various plugins like BP
 Docs, BP Followers, bbPress, as well as with a new nav item with no screen
 function - no errors.

 Would appreciate a few other testers.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4794#comment:3>
BuddyPress <http://buddypress.org/>
BuddyPress