[buddypress-trac] [BuddyPress] #4791: Previous activity for private groups not hidden from public stream

[buddypress-trac]

#4791: Previous activity for private groups not hidden from public stream
-------------------------+-----------------------------
 Reporter:  rachelbaker  |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Future Release
Component:  Groups       |     Version:  1.7
 Severity:  normal       |  Resolution:
 Keywords:               |
-------------------------+-----------------------------
Changes (by boonebgorges):

 * type:  defect (bug) => enhancement
 * milestone:  Awaiting Review => Future Release


Comment:

 Hi rachelbaker. This is more or less intentional. There are a couple
 reasons for it being this way:

 1. Think about the converse: You have a private/hidden group, full of
 private content. Then the admin flips the switch to make the group public.
 It's not clear you'd want that old content to become public, at least not
 by default.
 2. Activity is hidden by means of the `hide_sitewide` column in the
 activities table. You could theoretically change all of these values with
 a single SQL query, but it could be slow at scale. Moreover, a proper loop
 over the activity items would allow plugins to modify the behavior on an
 item-by-item basis; but looping would be much more process-intensive.

 If we're going to consider something for BP core, I'd suggest that it
 should be in the form of a prompt. When you change a group's privacy
 level, you'd be asked (maybe on a subsequent screen?) whether you also
 want to change the visibility of all previous activity items, with an
 explanation of the potential privacy issues of doing so. This would
 default to 'NO' (the current behavior).

 See also #2529, #3857

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4791#comment:1>
BuddyPress <http://buddypress.org/>
BuddyPress