[buddypress-trac] [BuddyPress] #4785: Decouple "visibility" and "access" properties

[buddypress-trac]

#4785: Decouple "visibility" and "access" properties
-------------------------+------------------
 Reporter:  smninja      |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  1.8
Component:  Groups       |     Version:  1.7
 Severity:  normal       |  Resolution:
 Keywords:               |
-------------------------+------------------
Changes (by boonebgorges):

 * keywords:  reporter-feedback =>
 * milestone:  Awaiting Review => 1.8


Comment:

 smninja - Thanks very much for the additional details.

 As for the issue that the ticket originally addresses - whether the ideas
 of "visibility" and "access" are convoluted in BP groups - I'm not
 convinced that this is anything more than a semantic point. That's not to
 say it's not important - we want our nomenclature to be as transparent as
 possible, to make the dev learning curve as non-steep as possible. But
 fundamentally, the fact that we use words like 'visibility' and 'public'
 here is not at the root of the problem.

 However, I'm in agreement that we should have a more sensible way of
 deciding which group tabs to show - we shouldn't be hardcoding the check
 like we are now. Also, I agree that it makes sense to allow plugins to put
 public tabs on private groups (though, fwiw, it should be done sparingly
 and with great documentation, because it threatens to wreck the
 distinction between public and private groups).

 I'm putting this into 1.8 because I think that the minimal solution -
 replacing the hardcoded check in bp-groups-loader.php with something more
 sensitive to the params in `BP_Group_Extension` - is something we can
 fairly easily do, and something that could have a nice impact.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4785#comment:4>
BuddyPress <http://buddypress.org/>
BuddyPress