[buddypress-trac] [BuddyPress] #4785: Decouple "visibility" and "access" properties

[buddypress-trac]

#4785: Decouple "visibility" and "access" properties
-------------------------------+------------------------------
 Reporter:  smninja            |       Owner:
     Type:  enhancement        |      Status:  new
 Priority:  normal             |   Milestone:  Awaiting Review
Component:  Groups             |     Version:  1.7
 Severity:  normal             |  Resolution:
 Keywords:  reporter-feedback  |
-------------------------------+------------------------------
Changes (by boonebgorges):

 * keywords:  access, visibility => reporter-feedback


Comment:

 > The "$visibility" variable used when extending BP_Group_Extension seems
 to infer the extension's tab will be visible to non-members @ line 1279
 :bp-groups-classes.php "Will this extension be visible to non-members of a
 group? Options: public/private" -- in practice, however, this does not
 seem to be the case.

 If this is true, it's a bug in the intended implementation. The
 `visibility` property is supposed to hide the tab, and also supposed to
 block access to the tab via direct URL.

 I will say, though, that 'private' in the sense of
 `BP_Group_Extension::visibility` is, by design, different from 'private'
 in the sense of private (vs hidden vs public) groups. Private group
 extensions have their display tabs visible to group members only. this is
 independent of more general group privacy levels. Are you suggesting that
 they be linked somehow?

 I'll take some time to investigate further to see if I can reproduce what
 you're reporting, but it would be helpful if you posted a working example
 that demonstrates the bug. Can you post the parts of your code that are
 relevant to the issue at hand, and describe what you're seeing vs what you
 expect to be seeing?

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4785#comment:1>
BuddyPress <http://buddypress.org/>
BuddyPress