[buddypress-trac] [BuddyPress] #4846: Theme compat is overaggressive in loading its files, especially JS

buddypress-trac noreply at wordpress.org
Mon Feb 25 01:00:37 UTC 2013


#4846: Theme compat is overaggressive in loading its files, especially JS
-----------------------------------+---------------------
 Reporter:  boonebgorges           |       Owner:
     Type:  defect (bug)           |      Status:  closed
 Priority:  high                   |   Milestone:  1.7
Component:  Theme                  |     Version:  1.7
 Severity:  critical               |  Resolution:  fixed
 Keywords:  2nd-opinion has-patch  |
-----------------------------------+---------------------

Comment (by boonebgorges):

 Thanks for the feedback, all. It sounds like `current_theme_supports(
 'buddypress' )` is generally agreed to be the best way forward. I'm going
 to put a post up on bpdevel explaining what theme authors have to do.

 For the moment, I'm not planning on doing any of the automated cleanup
 items I suggest above (1, 2, and 4). Basically, each one would introduce
 overhead in BuddyPress, and we should be encouraging theme authors to do
 it the "right" way.

 For the moment, I am *not* going to add a check for the 'buddypress' theme
 tag. (1) This also adds some overhead; and (2) I don't trust those tags -
 at least in the case of plugins, authors use the tag very promiscuously.

 Feel free to reopen for further discussion if you think that more needs to
 be done than r6822.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4846#comment:11>
BuddyPress <http://buddypress.org/>
BuddyPress


More information about the buddypress-trac mailing list