[buddypress-trac] [BuddyPress] #4846: Theme compat is overaggressive in loading its files, especially JS

[buddypress-trac]

#4846: Theme compat is overaggressive in loading its files, especially JS
-----------------------------------+------------------
 Reporter:  boonebgorges           |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  high                   |   Milestone:  1.7
Component:  Theme                  |     Version:  1.7
 Severity:  critical               |  Resolution:
 Keywords:  2nd-opinion has-patch  |
-----------------------------------+------------------

Comment (by sbrajesh):

 Hi,
 just wanted to let you know that I did some tests on it too.
 Adding add_theme_support( 'buddypress' ) on after_setup_theme action did
 not solve the issue. buddypress.js and buddypress.css was getting loaded(I
 am on rev r6821 with WordPress Multisite Installation).

 I had to remove the 'bp_load_theme_functions' from 'bp_after_setup_theme'
 action and that stopped loading.

 I may be wrong, but if a theme registers support for !BuddyPress, should
 not we completely avoid using theme compat files in that case?

 There are other options too like woocommerce does(gives the user options
 to load the included css/js and the user can decide) but I  personally
 believe, if a theme registers support for !BuddyPress(if after_setup_theme
 hook is too late, we can check using theme tag), we should completely
 avoid loading the theme compat, otherwise It may create a mess.


 As a theme Author, I feel, we need more flexibility and control. I am  not
 sure If I want !BuddyPress to automatically inject some elements in my
 presentation of the theme if I am creating a theme specially for
 BuddyPress.

 For the themes, which does not register support for !BuddyPress, I believe
 it is fine to inject the content.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4846#comment:8>
BuddyPress <http://buddypress.org/>
BuddyPress