[buddypress-trac] [BuddyPress] #4622: Spaces allowed in screen names since 1.6 update

[buddypress-trac]

#4622: Spaces allowed in screen names since 1.6 update
------------------------------------+------------------
 Reporter:  oceanwidedesigns        |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  1.8
Component:  Members                 |     Version:  1.6
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+------------------
Changes (by r-a-y):

 * keywords:  dev-feedback needs-patch => dev-feedback has-patch


Comment:

 `01.patch` allows users to register with spaces.

 Because we're allowing users to register with spaces, there are a couple
 of things that needed to be addressed '''if'''
 `'BP_ENABLE_USERNAME_COMPATIBILITY_MODE'` '''is defined'''.

 The patch addresses:

 * Member permalinks in the member loop shouldn't fallback to
 `user_nicename` when a space is found in the username

 * For @mentions to work, we cannot allow spaces to be used, so in the
 patch, we will always use the `user_nicename`.

 * Needed to add additional template functions so we could grab the logged-
 in user nicename and the displayed user nicename to be used for the
 @mention name in the member header.

 ----

 The big problem here is changing the `member-header.php` template to use
 the new template function.

 This is a backpat problem for themes that have already overriden member-
 header.php in their custom themes.

 I see two options here:

 1. Make the change in the member-header.php and do a post on
 bpdevel.wordpress.com about this.

 2. Do not make the change and instead filter
 `bp_displayed_user_username()` to use the `user_nicename` for the member
 header only.  This kinda sucks.

 This is only a problem if 'BP_ENABLE_USERNAME_COMPATIBILITY_MODE' is
 defined and if there are users with spaces in their `user_login`.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4622#comment:19>
BuddyPress <http://buddypress.org/>
BuddyPress