[buddypress-trac] [BuddyPress] #4849: BP Theme Compat My Favorites extra tab in member's profile activity page

[buddypress-trac]

#4849: BP Theme Compat My Favorites extra tab in member's profile activity page
--------------------------+------------------------------
 Reporter:  imath         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Activity      |     Version:  1.7
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------
Changes (by boonebgorges):

 * keywords:  has-patch dev-feedback => has-patch


Comment:

 Thanks, DJPaul. Looks like I was missing something after all. That JS does
 double duty: it fires when an activity item is favorited from a member's
 stream (which leads to the problem imath points out above), and *also*
 when favoriting an item from the global Activity directory. In the latter
 case, we *do* want to add the My Favorites tab.

 So, I'm going to commit a fix that only attempts to add My Favorites when
 `#activity-mentions-personal-li` is not found - which is to say, it won't
 happen in the context of a members page, where there's already a Mentions
 tab. Also, because the original issues isn't taking place in bp-default
 (because of the more specific `li` selector), I'm going to leave it alone
 - if it ain't broke, etc.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4849#comment:3>
BuddyPress <http://buddypress.org/>
BuddyPress