[buddypress-trac] [BuddyPress] #4849: BP Theme Compat My Favorites extra tab in member's profile activity page

[buddypress-trac]

#4849: BP Theme Compat My Favorites extra tab in member's profile activity page
------------------------------------+------------------------------
 Reporter:  imath                   |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Activity                |     Version:  1.7
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------------------
Changes (by boonebgorges):

 * keywords:  has-patch => has-patch dev-feedback


Comment:

 Confirmed.

 This is a very odd issue. This JS is intended to insert a My Favorites
 button. It just so happens that it hasn't worked in previous versions of
 BP. It seems to me that we don't actually want this functionality at all,
 and so we should consider just removing the 'My Favorites' lines
 altogether.

 FWIW, imath's patch "fixes" the issue by re-breaking the JS - li#activity-
 mentions fails to select any element on the page.

 Other devs - could you take a look and see if I'm understanding the issue
 correctly? If I'm right and this code has never worked, then there's no
 harm in removing it for 1.7. But it's possible that I'm not right.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4849#comment:1>
BuddyPress <http://buddypress.org/>
BuddyPress