[buddypress-trac] [BuddyPress] #4847: Misplaced 'bp_custom_profile_edit_fields' action hook in default theme

[buddypress-trac]

#4847: Misplaced 'bp_custom_profile_edit_fields' action hook in default theme
-------------------------+-----------------------------
 Reporter:  dontdream    |      Owner:
     Type:  enhancement  |     Status:  new
 Priority:  normal       |  Milestone:  Awaiting Review
Component:  Theme        |    Version:  1.6.2
 Severity:  normal       |   Keywords:
-------------------------+-----------------------------
 In file 'buddypress/bp-themes/bp-default/members/single/profile/edit.php'
 the line:

 {{{
 do_action( 'bp_custom_profile_edit_fields' );
 }}}

 appears after the block of code that handles the field visibility, while
 it should appear before that block. In other words that 'do_action' line
 should be moved from line 136 to line 116.

 Why do I think so? The 'bp_custom_profile_edit_fields' action hook is
 apparently intended to handle custom profile field types, see for instance
 the plugin 'Buddypress Xprofile Custom Fields Type'. The present placement
 of the 'do_action' line makes the custom fields appear after their
 visibility properties, while the built-in types appear before them.
 Probably when the visibility properties where added, they were
 inadvertently added before the hook.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4847>
BuddyPress <http://buddypress.org/>
BuddyPress