[buddypress-trac] [BuddyPress] #4843: Are you Sure/Confirm action is not Run on BuddyPress 1.7 beta 1

buddypress-trac noreply at wordpress.org
Thu Feb 21 01:00:34 UTC 2013

#4843: Are you Sure/Confirm action is not Run on BuddyPress 1.7 beta 1
 Reporter:  sbrajesh      |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Core          |    Version:  1.7
 Severity:  normal        |   Keywords:
 I am testing BuddyPress 1.7 beta 1 with standard WordPress(Not multisite)
 and I am using the bp-default theme.

 The confirm actions are not run. If you click on delete activity the
 activity is deleted silently and the same goes for any action which
 requires confirmation(I haven't tested them all though).

 The problem is in Bp 1.7, the check for click on confirm link is delegated
 to body while the activity delete is delegated to div.activity.

 Since in event bubbling, the event is captured by the functions attached
 to div.activity before it reaches to body, no confirmation message is
 asked and the action gets completed silently.

 It is a regression from Bp 1.6(1.6 had trouble showing the confirm message
 for elements loaded via ajax).

 I will recommend that we revert the changes in bp_core_confirmation_js to
 the BP 1.6.x code unless there is a complete review of the included
 javascript for event delegations/priority.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4843>
BuddyPress <http://buddypress.org/>

More information about the buddypress-trac mailing list