[buddypress-trac] [BuddyPress] #4809: broken logic in bp_core_wpsignup_redirect causes redirect loop to register page

[buddypress-trac]

#4809: broken logic in bp_core_wpsignup_redirect causes redirect loop to register
page
--------------------------+-----------------------------
 Reporter:  tometzky      |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  Members       |    Version:  1.6.2
 Severity:  major         |   Keywords:
--------------------------+-----------------------------
 A broken logic in `bp_core_wpsignup_redirect()` function causes buddypress
 1.6.4 to loop endlessly on every page other than `/`.

 I think it is supposed to trigger a redirect to `bp_get_signup_page()`
 when:[[BR]]
 ([[BR]]
   `$_SERVER['SCRIPT_NAME']` contains `wp-signup.php`[[BR]]
   or/and (I don't know which)[[BR]]
   `$_GET['action']` is equal to `register`[[BR]]
 )[[BR]]
 and[[BR]]
 `register.php` or `registration/register.php` template exists.

 But instead it triggers a redirect when `$_SERVER['SCRIPT_NAME']` is
 empty!

 I'm attaching a proposed patch, but I'm assuming that a redirect should be
 performed only when `$_SERVER['SCRIPT_NAME']` contains `wp-signup.php` and
 also `$_GET['action']` is equal to `register`.

 There are several people on support forums which have problems with
 endless loop to register page.

-- 
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4809>
BuddyPress <http://buddypress.org/>
BuddyPress