[buddypress-trac] [BuddyPress] #5300: Notifications from inactive components are rendered on the Notifications panel

[buddypress-trac]

#5300: Notifications from inactive components are rendered on the Notifications
panel
-----------------------------------+------------------------------
 Reporter:  boonebgorges           |       Owner:  johnjamesjacoby
     Type:  defect (bug)           |      Status:  reopened
 Priority:  normal                 |   Milestone:  1.9.1
Component:  Notifications          |     Version:
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |
-----------------------------------+------------------------------
Changes (by imath):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Hi @jjj, @boone,

 First, i'm really sorry and disappointed by myself about #5290, i was so
 obsessed by the admin bar that i completely missed the notifications
 panel.

 @jjj applying your patch solves the select query, but i think i understand
 why @boone was modifying the get_where_sql() function. Because, there's
 also a count query and using r7677, the count is taking in account
 notifications of inactive components.

 so i suggest the diff attached to also restrict the count to active
 components

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5300#comment:11>
BuddyPress <http://buddypress.org/>
BuddyPress