[buddypress-trac] [BuddyPress] #5301: New buddypress 1.9 bug

[buddypress-trac]

#5301: New buddypress 1.9 bug
--------------------------+----------------------
 Reporter:  michaello13   |       Owner:
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:
Component:  Core          |     Version:  1.9
 Severity:  normal        |  Resolution:  wontfix
 Keywords:                |
--------------------------+----------------------
Changes (by boonebgorges):

 * status:  new => closed
 * resolution:   => wontfix
 * milestone:  Awaiting Review =>


Comment:

 OK, here's the situation.

 Atahualpa is not using WP's native template loading logic. Its sole
 template is index.php, and then it uses custom logic to decide what should
 be shown on a given page. The relevant function for the purpose of
 BuddyPress content is `bfa_post_bodycopy()`. This function decides whether
 to display the entire post content (`the_content()`) or just an excerpt
 (`the_excerpt()`) based on a number of conditions. BP's theme
 compatibility is designed to work with `the_content()`, but strictly
 speaking, it mostly works with `the_excerpt()` too (because of some shared
 underpinnings).

 The problem is with stripped HTML tags. Prior to 1.9, BuddyPress echoed
 its buffered content, effectively killing anything that came after it. So,
 it skipped any custom filters on stripped tags, such as those that appear
 in `bfa_wp_trim_excerpt()`. In #5156, we discussed this behavior and
 decided it was a bug; [7386] fixes it. So now, in the case of Atahualpa,
 we have an instance where (a) the theme is awkwardly deciding to use
 `the_excerpt()` instead of `the_content()`, *and* (b) it's stripping HTML
 tags from the excerpt as modified by BP's theme compat system, which
 results in a markup-free block of text.

 As an immediate workaround, I recommend that Atahualpa users go to
 Dashboard > Appearance > Atahualpa Theme Options > Configure EXCERPTS, and
 change the value of "Don't strip these tags" to
 `<form><ul><li><label><select><option><img><span><div><a><p>`. This allows
 the necessary HTML tags through Atahualpa's excerpt filters.

 The "correct" fix is probably for Atahualpa to use `the_content()` for
 BuddyPress pages, probably by another conditional switch in
 `bfa_post_bodycopy()` (or maybe via filter). I have no idea whether the
 Atahualpa devs would be open to such a fix; in the past they have ignored
 my patches, so I'm not eager to try.

 I don't think there's anything for us to fix in BuddyPress, because this
 issue is really due to Atahualpa doing a number of odd things in a row.
 Closing as wontfix. If someone would like to post the "don't strip these
 tags" fix to the Codex, that'd be great.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5301#comment:6>
BuddyPress <http://buddypress.org/>
BuddyPress