[buddypress-trac] [BuddyPress] #5275: WordPress Network Admin Users unspam after BuddyPress user's profile capabilities spam doesn't unspam user

[buddypress-trac]

#5275: WordPress Network Admin Users unspam after BuddyPress user's profile
capabilities spam doesn't unspam user
--------------------------+------------------------------
 Reporter:  imath         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Members       |     Version:  1.8.1
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------

Comment (by r-a-y):

 Thanks for the thorough analysis, imath.

 > in a Multisite config we shouldn't update at all this user_status field,
 but i realized that doing so could cause other bugs, as there must be a
 lot of spammed users with a user_status field set to 1 and a spam field
 set to 1 in the different Multisite configs using BuddyPress, and in a
 case of a Multisite to single switch, spammed users might become
 unspammed..

 Same with switching from a single-site to multisite install.  I think your
 patch is an improvement.  Though, there might be some reasons as to why
 the current code is the way it is.  Need another core dev to chime in.

 If we're thinking of the current codebase, the problem lies in the
 `bp_is_user_spammer()` function and the way we're checking the `spam` and
 `user_status` fields.

 I've attached an initial patch that addresses the problem without needing
 imath's patch.  However, we should definitely look at imath's patch as
 well.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5275#comment:2>
BuddyPress <http://buddypress.org/>
BuddyPress