[buddypress-trac] [BuddyPress] #5130: Synchronizing activity comments to main component

[buddypress-trac]

#5130: Synchronizing activity comments to main component
-------------------------+--------------------
 Reporter:  r-a-y        |       Owner:  r-a-y
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  1.9
Component:  Core         |     Version:  1.2
 Severity:  normal       |  Resolution:
 Keywords:               |
-------------------------+--------------------

Comment (by DJPaul):

 I like the callback function in the component loader that handles activity
 comments. We should pull that into a separate patch and get that committed
 early.

 I dislike the approach that `bp_blogs_sync_add_from_activity_comment()` is
 taking. To summarise the patch, after an activity comment is posted on a
 blog post, we're creating a WP Comment on that post. And it handles
 removing activity comments after a WP Comment is deleted.

 But, we already track new blog comments with the existing
 `bp_blogs_record_comment()` function.

 I would suggest a more logical approach is that if someone leaves an
 activity reply to a blog post activity item, we only create the blog
 comment. The existing code will take care of creating the activity item.

 We'll definitely need to handle comment deletion sync that you've
 highlighted.


 > As noted in the ticket description, in WP, when a parent comment is
 deleted, the child comments are moved up a level, while BP simply deletes
 all activity children.

 Can't we just do the same?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5130#comment:3>
BuddyPress <http://buddypress.org/>
BuddyPress